Revert "🔥Remove static Default getters, obsoleted by UnitsNetSetup"#1480
Merged
angularsen merged 1 commit intorelease/v6from Dec 29, 2024
Merged
Revert "🔥Remove static Default getters, obsoleted by UnitsNetSetup"#1480angularsen merged 1 commit intorelease/v6from
angularsen merged 1 commit intorelease/v6from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v6 #1480 +/- ##
==========================================
- Coverage 86% 86% -1%
==========================================
Files 298 298
Lines 30515 30519 +4
==========================================
Hits 26405 26405
- Misses 4110 4114 +4 ☔ View full report in Codecov by Sentry. |
angularsen
force-pushed
the
revert-1475-agl/rem-default
branch
from
1ee3f76 to
b0180c6
Compare
angularsen
added a commit
that referenced
this pull request
Dec 29, 2024
Per [discussion ](#1475 (comment)) in v6, we no longer want to remove these. Already reverted in v6 with #1480
This was referenced Dec 29, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1475
This reverts commit a3c32b6.