Skip to content

feat(tui): add session_list_limit for session picker (#6137)#6138

Open
CasualDeveloper wants to merge 4 commits intoanomalyco:devfrom
CasualDeveloper:feat/tui-message-limit
Open

feat(tui): add session_list_limit for session picker (#6137)#6138
CasualDeveloper wants to merge 4 commits intoanomalyco:devfrom
CasualDeveloper:feat/tui-message-limit

Conversation

@CasualDeveloper
Copy link
Contributor

@CasualDeveloper CasualDeveloper commented Dec 24, 2025 •
edited
Loading

Problem

The session picker loads all sessions by default, which can become slow with hundreds or thousands of sessions.

Solution

  • Add tui.session_list_limit config (default 150)
  • Apply the limit only when not searching (search still uses server-side limit 30)
  • Keep the current session visible even when capped (tie-safe ordering)
  • Add a TUI tip for discoverability
  • Regenerate SDK OpenAPI/types

Notes

Copilot AI review requested due to automatic review settings December 24, 2025 23:46
Copilot AI reviewed Dec 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable message_limit option to control the number of messages loaded per session in the TUI. The default value remains 100, but users can now configure it up to 10,000 messages through the config file.

  • Add message_limit configuration field to TUI schema with validation constraints (1-10,000)
  • Update implementation to use the configured value with fallback to 100
  • Generate corresponding TypeScript type definitions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/sdk/openapi.json Adds message_limit field to the schema with integer constraints (1-10,000) and description
packages/sdk/js/src/v2/gen/types.gen.ts Generated TypeScript types for the new message_limit config option
packages/sdk/js/src/gen/types.gen.ts Generated TypeScript types with incorrect default value in documentation
packages/opencode/src/config/config.ts Adds Zod schema validation for message_limit with proper constraints
packages/opencode/src/cli/cmd/tui/context/sync.tsx Updates message loading to use configured limit with fallback to 100

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 24, 2025

Fixed the inconsistent default value in the SDK types (was 500, now correctly 100). Thanks Copilot!

@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 24, 2025

Fixed second hardcoded 100 in the message.updated event handler at line 191. Without this, new messages arriving during active sessions would trim the array back to 100, defeating the configurable limit.

@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 25, 2025 •
edited
Loading

I have a working implementation ready - typechecks pass.

@ariane-emory
Copy link
Contributor

ariane-emory commented Dec 25, 2025 •
edited
Loading

@CasualDeveloper I also want to see this feature. I've had a half-finished PR in my pocket for a while that addresses this (and also makes the length of session_list similarly configurable) I haven't found the time to finish it and yours looks like it may be cleaner than mine.

I cordially invite you to steal anything you think might be useful from my unfinished PR: ariane-emory#43

The team may (or may not) conclude that this also resolves my original Issue on the topic, #4918.

@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 25, 2025

@ariane-emory Thanks for linking your PR! I've incorporated session_list_limit from your work. Kept the implementation simpler (no "none" option, proper types instead of as any casts). Added a reference to #4918 in the PR description.

@CasualDeveloper CasualDeveloper force-pushed the feat/tui-message-limit branch 2 times, most recently from ef4a090 to 4a4438c Compare December 25, 2025 03:46
@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 25, 2025

Re-committed with valid GPG signature. PR ready.

@CasualDeveloper CasualDeveloper force-pushed the feat/tui-message-limit branch 3 times, most recently from 4596a07 to da1e0bc Compare December 26, 2025 06:51
@CasualDeveloper CasualDeveloper changed the title feat(tui): add configurable message_limit for session history [#4918] feat(tui): add configurable message_limit for session history Dec 26, 2025
@CasualDeveloper CasualDeveloper changed the title [#4918] feat(tui): add configurable message_limit for session history [#4918][#6137] feat(tui): add configurable message_limit for session history Dec 26, 2025
@CasualDeveloper CasualDeveloper changed the title [#4918][#6137] feat(tui): add configurable message_limit for session history [#6137] feat(tui): add configurable message_limit for session history Dec 26, 2025
@CasualDeveloper CasualDeveloper changed the title [#6137] feat(tui): add configurable message_limit for session history [6137] feat(tui): add configurable message_limit for session history Dec 26, 2025
@CasualDeveloper CasualDeveloper changed the title [6137] feat(tui): add configurable message_limit for session history [#6137] feat(tui): add configurable message_limit for session history Dec 26, 2025
@CasualDeveloper CasualDeveloper changed the title [#6137] feat(tui): add configurable message_limit for session history feat(tui): add configurable message_limit for session history (#6137) Dec 26, 2025
@CasualDeveloper CasualDeveloper force-pushed the feat/tui-message-limit branch 5 times, most recently from 872e100 to 1e84d56 Compare December 30, 2025 19:06
@CasualDeveloper
Copy link
Contributor Author

CasualDeveloper commented Dec 30, 2025

Will continue rebasing on top of release tags as they're set.

@CasualDeveloper CasualDeveloper changed the title feat(tui): add session_list_limit for session picker feat(tui): add session_list_limit for session picker (#6137) Jan 17, 2026
@CasualDeveloper CasualDeveloper force-pushed the feat/tui-message-limit branch 9 times, most recently from 325c7f5 to 8fc7ac0 Compare January 23, 2026 19:20
@CasualDeveloper CasualDeveloper force-pushed the feat/tui-message-limit branch 7 times, most recently from c0282dc to a566be1 Compare January 30, 2026 03:44
@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Closed
@ryanwyler ryanwyler mentioned this pull request Feb 22, 2026
Closed
@CasualDeveloper
feat(config): add session_list_limit schema
30b62bb 
Add session_list_limit to both legacy config migration schema and
current tui.json schema so the setting is recognized on latest dev.
@CasualDeveloper
feat(tui): cap session list and keep current
61f61dd 
Apply session_list_limit from tui config and preserve active-session
visibility when the list is capped.
@CasualDeveloper
test(tui): cover session list limit selection
13626f2 
Add focused tests for capping behavior, search bypass, active-session
preservation, and equal-timestamp ordering.
@CasualDeveloper
docs(tui): add session_list_limit tip
eddffb9 
Add a home-screen tip for tui.session_list_limit and resolve duplicate
wording introduced during rebase conflict resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot scroll to beginning of long conversations (message limit hardcoded to 100) (#6138)

4 participants

@CasualDeveloper @ariane-emory @benitogonzalezh