feat(file-logger): support standard output for file logger plugins#8681
feat(file-logger): support standard output for file logger plugins#8681e1ijah1 wants to merge 11 commits intoapache:masterfrom
Conversation
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Can you add a test in https://github.com/apache/apisix/tree/master/t/cli?
I'm not quite sure how to capture the standard output in E2E testing. Could you please give me some hints if you're available? @spacewander |
You can add a custom configuration to let APISIX don't run as a daemon. See https://github.com/apache/apisix/blob/master/docs/en/latest/customize-nginx-configuration.md |
The test has been added. Please take a look if you're available. @spacewander |
e1ijah1
requested review from
spacewander and
tokers
and removed request for
spacewander and
tokers
|
@spacewander It looks like the connection to the ETCD in one environment is down, causing CI to fail. Would you mind restarting the CI and reviewing my code? |
chore: fmt code chore: add test chore: fmt code chore: fmt code chore: fix lint chore: fmt code chore: fmt code
chore: remove specify listen port in test config chore: improve the code
fix lint fix: add test path fix ci fix test fix test
| util.execute_cmd(env.openresty_args) | ||
| local data, err = util.execute_cmd(env.openresty_args) | ||
| if not err and data and data ~= "" then | ||
| print(data) |
There was a problem hiding this comment.
It is useless to print the access log only after the Nginx exited.
| @@ -0,0 +1,82 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
Could we remove the intermediate directory, so this file can be tested without modifying the ci script?
3 participants
Description
support standard output for file logger plugins
Fixes #6797
Checklist