Implement arrow-row encoding/decoding for view types#5922
Merged
alamb merged 17 commits intoapache:masterfrom Jun 24, 2024
Merged
Implement arrow-row encoding/decoding for view types#5922alamb merged 17 commits intoapache:masterfrom
alamb merged 17 commits intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5921 .
Rationale for this change
The core of this pr is simple, just simple logic to allow GenericByteViewArray to be encoded/decoded to arrow-row.
To make things easy (and elegant), I made some opinionated changes:
ArrayOrd, so that the function can be used by anyone who have access to GenericByteView, rather than depending onarrow-ordGenericByteArraytoGenericByteViewArrayto GenericByteViewArray (rather than in the casting subcrate, for the same reason).What changes are included in this PR?
Are there any user-facing changes?