Draft
Conversation
github-actions
bot
added
parquet
brancz
force-pushed
the
dict-id-ipc-only
branch
3 times, most recently
from
d185110 to
6042909
Compare
Contributor
Author
|
Actually while debugging the test failure, I realized I can split up this PR some more, by just opening the removal of the preserving dict id code paths. |
Contributor
Author
|
Rebasing this on #7940 now. |
alamb
pushed a commit
that referenced
this pull request
Jul 18, 2025
# Which issue does this PR close? Does not yet close, but contributes towards: - #6356 - #5981 - #1206 # Rationale for this change See the above issues. And this is a follow up to * #6711 * #6873 This was also split out from: #7929 # What changes are included in this PR? This removes the API to allow preserving `dict_id` set in the `Schema`'s `Field` within arrow-ipc and arrow-flight. This is in an effort to remove the `dict_id` field entirely and make it an IPC/flight-only concern. # Are these changes tested? Yes, all existing tests continue to pass. # Are there any user-facing changes? Yes, these previously (in 54.0.0) deprecated functions/fields are removed: * `arrow_ipc::DictionaryTracker.set_dict_id` * `arrow_ipc::DictionaryTracker::new_with_preserve_dict_id` * `arrow_ipc::IpcWriteOptions.with_preserve_dict_id` * `arrow_ipc::IpcWriteOptions.preserve_dict_id` (function and field) * `arrow_ipc::schema_to_fb` * `arrow_ipc::schema_to_bytes`
Contributor
|
Close / reopen to rerun CI (I think github actions was having problems previously) |
Contributor
Author
|
One of the tests is actually failing correctly (one of the integration tests), and I've realized what I need to do, but I'll need a few days to get to it. I'll make sure to ping you when I've got it fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Does not yet close, but contributes towards:
dict_idequality in field merging #6356dict_idfromarrow_schema::field::Fieldand make dictionary IDs an internal implementation detail of flight encoding/decoding #5981Rationale for this change
See the above issues. And this is a follow up to
dict_id#6873This was also split out from: #7467
What changes are included in this PR?
The required changes, so that nothing depends on the canonical
Schema'sFieldcontaining thedict_idfield anymore, so that as a follow up, thedict_idfield can actually be removed from the deprecated function signatures and remove the field itself.Are these changes tested?
All tests continue to pass.
Are there any user-facing changes?
The function signatures of these publicly facing APIs changed to provide the appropriate access to the dict ID as it is represented in the respective IPC message(s):
@tustvold @alamb @thinkharderdev @adriangb