[Variant] Rename VariantShreddingRowBuilder to VariantToArrowRowBuilder#8344
Merged
alamb merged 2 commits intoapache:mainfrom Sep 14, 2025
Merged
[Variant] Rename VariantShreddingRowBuilder to VariantToArrowRowBuilder#8344alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
CC @alamb @codephage2020 -- a quickie |
alamb
approved these changes
Sep 14, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @scovich and @codephage2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
The "shredding row builder" name is a bit hard to understand. And now that we have
ArrowToVariantRowBuilder(used bycast_to_variant), it makes sense to rename these asVariantToArrowRowBuildersince that's actually what they do.While we're at it, rename
variant_get/mod.rsas justvariant_get.rs, since it was the only file in its directory.What changes are included in this PR?
Just the rename (which includes a couple of file renames).
Are these changes tested?
Pure code movement/rename -- compilation suffices
Are there any user-facing changes?
No