Skip to content

only clean details and annotations when this template no longer exists#10728

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:ghi10600-guardTemplateSettings
Apr 17, 2025
Merged

only clean details and annotations when this template no longer exists#10728
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:ghi10600-guardTemplateSettings

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Apr 15, 2025 •
edited
Loading

… on any zone

Description

This PR...

Fixes: #10600

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.19.3 milestone Apr 15, 2025
@DaanHoogland DaanHoogland linked an issue Apr 15, 2025 that may be closed by this pull request
Template settings are lost when its deleted in one zone #10600
Closed
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f13cf59) to head (8c9a24d).
Report is 4 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../com/cloud/template/HypervisorTemplateAdapter.java 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10728   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11332    11333    +1     
=========================================
  Files          5415     5415           
  Lines        474893   474898    +5     
  Branches      57920    57920           
=========================================
+ Hits          72046    72049    +3     
- Misses       394792   394795    +3     
+ Partials       8055     8054    -1
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Apr 15, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13063

@kiranchavala kiranchavala self-assigned this Apr 17, 2025
@kiranchavala
Copy link
Member

kiranchavala commented Apr 17, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 17, 2025

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

kiranchavala
kiranchavala approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested the issue manually

  • Have cloudstack env with 2 zones
  • Register a template a zone 1
  • Add template setting UEFI=secure
  • Copy the template to zone 2
  • Delete the template in zone2

The template setting is still persisted on Zone 1

@DaanHoogland DaanHoogland marked this pull request as ready for review April 17, 2025 10:26
@blueorangutan
Copy link

blueorangutan commented Apr 17, 2025

[SF] Trillian Build Failed (tid-13036)

weizhouapache
weizhouapache approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland merged commit 8c9216d into apache:4.19 Apr 17, 2025
24 of 25 checks passed
@DaanHoogland DaanHoogland deleted the ghi10600-guardTemplateSettings branch April 17, 2025 10:55
@DaanHoogland DaanHoogland mentioned this pull request Apr 17, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@DaanHoogland @dhslove
only clean details and annotations when this tamplate no longer exist…
37b9d7c 
…s on any zone (apache#10728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@kiranchavala kiranchavala

Labels

None yet

Projects

ACS 4.20.1
Status: Done

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

Template settings are lost when its deleted in one zone

4 participants

@DaanHoogland @blueorangutan @kiranchavala @weizhouapache