[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs#1598
[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs#1598asfgit merged 1 commit intoapache:masterfrom
Conversation
syed
force-pushed
the
vhd-compressed-size
branch
from
841783f to
f9a8701
Compare
|
@syed my understanding is that you have tested this fix with swift in our lab. That is correct? I will get CI run against it to make sure this does not break anything outside swift. |
|
Yes @swill I've tested this on my local setup. On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens [email protected]
|
|
Thank you. I have CI running and I should have results later tonight. |
CI RESULTSAssociated Uploads
Uploads will be available until Comment created by |
|
This is coming back clean. Since it fixes issues in 4.9, I think it should be merged... |
| } | ||
|
|
||
| protected long getTemplateVirtualSize(File file) throws IOException { | ||
| protected long getTemplateVirtualSize(File file) throws IOException { |
There was a problem hiding this comment.
Can you fix the method indentation here. This should not be indented that extra tab.
|
@syed, can you do a once through and clean up some of the white space issues in this diff. I have highlighted a couple. The method indent is the most important, but there are a few other cases where the white space can be cleaned up as well. Thx... |
syed
force-pushed
the
vhd-compressed-size
branch
2 times, most recently
from
eabf3ef to
c5ad04c
Compare
|
@swill. I've fixed the whitespaces and rebased everything. Should be good now. |
|
Good enough. Thanks... :) |
|
@swill if you can merge this before you cut the release, it would be awesome. |
syed
force-pushed
the
vhd-compressed-size
branch
from
c5ad04c to
b0247b5
Compare
[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDsWith object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file. Before the fix: template.properties on Swift ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=2894447637315205059 ``` After the fix ``` uniquename=routing-1 filename=routing-1.vhd size=263417314 virtualsize=3145728000 ``` Look at the `virutalsize` in both cases * pr/1598: [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs Signed-off-by: Will Stevens <[email protected]>
3 participants
With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the
VHDProcessorincorrectly calculates the virutal size leading to the template being useless. This fix tries to guess the virtual size by partially decompressing it and falls back to a sensible default which is the size of the file.Before the fix: template.properties on Swift
After the fix
Look at the
virutalsizein both cases