[branch-49] Backport PR #16995 to branch-49#17068
Merged
xudong963 merged 1 commit intoapache:branch-49from Aug 7, 2025
Merged
Conversation
…ec of the correct size (apache#16995) * apache#16994 Ensure CooperativeExec#maintains_input_order returns a Vec of the correct size * apache#16994 Extend default ExecutionPlan invariant checks Add checks that verify the length of the vectors returned by methods that need to return a value per child. (cherry picked from commit 2968331)
5 tasks
zhuqi-lucas
approved these changes
Aug 7, 2025
Contributor
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM , thank you @pepijnve !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CooperativeExecincorrectly implementsmaintains_input_order#16994.Rationale for this change
See #16995
What changes are included in this PR?
See #16995
Are these changes tested?
See #16995
Are there any user-facing changes?
No