Only add outer filter once when transforming exists/in subquery to join#4944
Only add outer filter once when transforming exists/in subquery to join#4944alamb merged 4 commits intoapache:masterfrom
Conversation
|
cc @mingmwang, this may be relative to your work #4366. |
|
Looks like the method's comment is out of date. Could you please also fix them in this PR ? /// # Arguments
///
/// * subqry - The subquery portion of the `where exists` (select * from orders)
/// * negated - True if the subquery is a `where not exists`
/// * filter_input - The non-subquery portion (from customers)
/// * outer_exprs - Any additional parts to the `where` expression (and c.x = y)
fn optimize_exists(
query_info: &SubqueryInfo,
outer_input: &LogicalPlan,
outer_other_exprs: &[Expr],
) |
This PR didn't addressed #4366. I know where the issue is. In this PR, you can just focus on fixing the duplicated Filters bug. |
Fixed. |
avantgardnerio
left a comment
There was a problem hiding this comment.
LGTM, pending the doc fix.
|
Thanks @avantgardnerio and @ygf11 |
|
Benchmark runs are scheduled for baseline = 22d106a and contender = e566bfc. e566bfc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4914.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?