Skip to content

[sqllogictest] Create empty tables#5026

Merged
alamb merged 1 commit intoapache:masterfrom
melgenek:4396-create-empty-table
Jan 23, 2023
Merged

[sqllogictest] Create empty tables#5026
alamb merged 1 commit intoapache:masterfrom
melgenek:4396-create-empty-table

Conversation

@melgenek
Copy link
Contributor

@melgenek melgenek commented Jan 22, 2023

Which issue does this PR close?

Closes #4396.

Rationale for this change

What changes are included in this PR?

The change allows the creation of empty tables in sqllogictest.

Are these changes tested?

Github Actions run sqllogictest.

Are there any user-facing changes?

Planner's build_schema was made public. I am not sure if this is a problem.

@xudong963 @mvanschellebeeck

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Jan 22, 2023
@melgenek melgenek mentioned this pull request Jan 22, 2023
Closed
alamb
alamb approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @melgenek

datafusion/core/tests/sqllogictests/test_files/ddl.slt

# Should insert into an empty table
statement ok
insert into table_without_values values (1, 2), (2, 3), (2, 4);
Copy link
Contributor

@alamb alamb Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

datafusion/sql/src/planner.rs
}

pub(crate) fn build_schema(&self, columns: Vec<SQLColumnDef>) -> Result<Schema> {
pub fn build_schema(&self, columns: Vec<SQLColumnDef>) -> Result<Schema> {
Copy link
Contributor

@alamb alamb Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to make public 👍

@alamb
Copy link
Contributor

alamb commented Jan 23, 2023

I really appreciate your efforts to drive sqllogictests forward @melgenek -- it is great working with you

@alamb alamb merged commit 25ab1f9 into apache:master Jan 23, 2023
@ursabot
Copy link

ursabot commented Jan 23, 2023

Benchmark runs are scheduled for baseline = 64714ee and contender = 25ab1f9. 25ab1f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@xudong963
Copy link
Member

xudong963 commented Jan 23, 2023

Cool, thanks @melgenek

@melgenek melgenek deleted the 4396-create-empty-table branch January 25, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate sql SQL Planner sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support CREATE TABLE table_name(...schema_fields)

4 participants

@melgenek @alamb @ursabot @xudong963