GROOVY-9175 migrate private methods to protected#956
Merged
daniellansun merged 1 commit intoapache:masterfrom Jun 28, 2019
Merged
GROOVY-9175 migrate private methods to protected#956daniellansun merged 1 commit intoapache:masterfrom
daniellansun merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
PR failed to build with JDK10. Do we still have ti support this JDK version given that it has been superseded by JDK 11? |
Contributor
|
Let me try to restart the build with JDK10. As far as I know, Groovy 3 requires Java 8+(not Java 11+). |
Contributor
|
All builds are green ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.apache.org/jira/browse/GROOVY-9175