refactor(core): improve backend code by flow idea suggests#2000
Merged
javeme merged 2 commits intoapache:masterfrom Nov 11, 2022
Merged
refactor(core): improve backend code by flow idea suggests#2000javeme merged 2 commits intoapache:masterfrom
javeme merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
============================================
+ Coverage 62.41% 66.38% +3.97%
Complexity 976 976
============================================
Files 482 482
Lines 41450 41449 -1
Branches 5896 5890 -6
============================================
+ Hits 25870 27516 +1646
+ Misses 13034 11232 -1802
- Partials 2546 2701 +155
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
reviewed
Nov 2, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/BackendException.java
Outdated
Show resolved
Hide resolved
| StringBuilder sb = new StringBuilder(1 + idString.length()); | ||
| sb.append(id.type().prefix()).append(idString); | ||
| return sb.toString(); | ||
| return id.type().prefix() + idString; |
Member
There was a problem hiding this comment.
should warn if it influence the performance. some suggestions are not perf friendly
Contributor
Author
There was a problem hiding this comment.
这里就两个string，用StringBuilder代价更大
Member
There was a problem hiding this comment.
也是, 而且高版本 JDK 编译器似乎已经会自动判断开销转换了. (当然我不确定是从 JDK 几开始的)
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Nov 2, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/AbstractCache.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/AbstractCache.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/BackendException.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Condition.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Query.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinaryEntryIterator.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/ram/IntObjectMap.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/ram/IntObjectMap.java
Outdated
Show resolved
Hide resolved
imbajin
previously approved these changes
Nov 7, 2022
Contributor
|
@jadepeng you can use |
Member
The It is safer and doesn't need to review the code again (avoid unnecessary manual rebase operations) TODO: I'll enable the |
zyxxoo
previously approved these changes
Nov 9, 2022
jadepeng
force-pushed
the
impove-backend-code
branch
from
ae5e0b2 to
b681523
Compare
imbajin
approved these changes
Nov 11, 2022
javeme
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.