Skip to content

refactor: improve rocksdb code#2002

Merged
javeme merged 2 commits intoapache:masterfrom
jadepeng:improve-rocksdb-code
Nov 3, 2022
Merged

refactor: improve rocksdb code#2002
javeme merged 2 commits intoapache:masterfrom
jadepeng:improve-rocksdb-code

Conversation

@jadepeng
Copy link
Contributor

@jadepeng jadepeng commented Nov 2, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #2002 (40a30f1) into master (19ef0ac) will decrease coverage by 0.01%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master    #2002      +/-   ##
============================================
- Coverage     70.50%   70.49%   -0.02%     
+ Complexity      724      677      -47     
============================================
  Files           453      453              
  Lines         39024    39024              
  Branches       5556     5556              
============================================
- Hits          27515    27511       -4     
- Misses         8810     8815       +5     
+ Partials       2699     2698       -1     
Impacted Files Coverage Δ
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 67.11% <ø> (ø)
...hugegraph/backend/store/rocksdb/RocksDBTables.java 74.44% <0.00%> (ø)
...h/backend/store/rocksdbsst/RocksDBSstSessions.java 47.65% <ø> (ø)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 73.46% <78.57%> (-0.05%) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 85.58% <100.00%> (+0.02%) ⬆️
...raph/backend/store/rocksdb/RocksDBStdSessions.java 75.64% <100.00%> (ø)
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.80% <0.00%> (-1.21%) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 76.36% <0.00%> (-0.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -943,7 +943,6 @@ public static final byte[] increaseOne(byte[] bytes) {
}
bytes[i] += 0x01;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could handle/fix it

@javeme javeme merged commit 0961959 into apache:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants