Fix bug: Closing iterators on errors for CassandraTable and MysqlTable#2014
Merged
javeme merged 4 commits intoapache:masterfrom Nov 14, 2022
Merged
Conversation
Contributor
Author
|
hi @javeme . Plz review. I noticed a similar issue for MysqlTable so added that as well as part of the PR |
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
Coverage 66.35% 66.36%
- Complexity 677 978 +301
==========================================
Files 482 482
Lines 41449 41457 +8
Branches 5890 5890
==========================================
+ Hits 27505 27512 +7
- Misses 11244 11248 +4
+ Partials 2700 2697 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Nov 10, 2022
Contributor
javeme
left a comment
javeme
left a comment
There was a problem hiding this comment.
Thanks for your contribution
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Outdated
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Outdated
Show resolved
Hide resolved
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks @javeme . I made the changes. |
javeme
reviewed
Nov 14, 2022
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Outdated
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Outdated
Show resolved
Hide resolved
imbajin
approved these changes
Nov 14, 2022
javeme
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1983