Skip to content

Adding try-with-resources block around PredictionTraverser#2016

Merged
javeme merged 2 commits intoapache:masterfrom
vamossagar12:traverser-resource-leak
Nov 15, 2022
Merged

Adding try-with-resources block around PredictionTraverser#2016
javeme merged 2 commits intoapache:masterfrom
vamossagar12:traverser-resource-leak

Conversation

@vamossagar12
Copy link
Contributor

Fixes #1818

@vamossagar12
Copy link
Contributor Author

@javeme , another small PR. Plz review. Thanks!

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2016 (833ce2f) into master (833ce2f) will not change coverage.
The diff coverage is n/a.

❗ Current head 833ce2f differs from pull request most recent head 895f249. Consider uploading reports for the commit 895f249 to get more accurate results

@@            Coverage Diff            @@
##             master    #2016   +/-   ##
=========================================
  Coverage     66.34%   66.34%           
  Complexity      978      978           
=========================================
  Files           482      482           
  Lines         41457    41457           
  Branches       5890     5890           
=========================================
  Hits          27506    27506           
  Misses        11251    11251           
  Partials       2700     2700           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution~

@javeme javeme force-pushed the traverser-resource-leak branch from 9ceca69 to 895f249 Compare November 14, 2022 15:07
@javeme
Copy link
Contributor

javeme commented Nov 14, 2022

I've updated the branch on the github page that caused the author is changed, which doesn't seem to be expected behavior.
rebase-update

@vamossagar12 can you please rebase on the latest master by git rebase -i master and git push -f again?

@imbajin
Copy link
Member

imbajin commented Nov 15, 2022

I've updated the branch on the github page that caused the author is changed, which doesn't seem to be expected behavior.
rebase-update

@vamossagar12 can you please rebase on the latest master by git rebase -i master and git push -f again?

could just use merge from master option(rather than rebase from master),merge it wont break the code commit/review

@javeme javeme merged commit b79a690 into apache:master Nov 15, 2022
@javeme
Copy link
Contributor

javeme commented Nov 15, 2022

It looks ok and doesn't change the actual author:
ahthor-ok

@vamossagar12
Copy link
Contributor Author

Thanks @javeme , @imbajin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Resource leak: 'traverser' is never closed

3 participants