Add test to ensure every table update has corresponding _apply_table_update function#952
Add test to ensure every table update has corresponding _apply_table_update function#952kevinjqliu wants to merge 4 commits intoapache:mainfrom
_apply_table_update function#952Conversation
kevinjqliu
force-pushed
the
kevinjqliu/enforce-table-update-dispatch
branch
from
be27ba3 to
edf0c17
Compare
kevinjqliu
changed the title
_apply_table_update function
kevinjqliu
force-pushed
the
kevinjqliu/enforce-table-update-dispatch
branch
from
edf0c17 to
c5bcea7
Compare
|
@kevinjqliu Since these 2 prs #1598 #1561 are now in main, I believe you can now rebase and merge this one |
|
Amazing! @grihabor thanks for the ping, let me rebase this PR |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
2 participants
This PR adds a test in to check that every
TableUpdateclass has a corresponding_apply_table_updatefunction.While looking at #864 and #950, I noticed that some TableUpdate classes do not have corresponding
_apply_table_updatefunction.I think we should enforce this in tests so that any future TableUpdate have the necessary
_apply_table_updateto process the update.