Skip to content

MINOR: Update build and test dependencies for 3.5#13199

Merged
stanislavkozlovski merged 1 commit intoapache:trunkfrom
ijuma:build-dep-update-3.5
Feb 9, 2023
Merged

MINOR: Update build and test dependencies for 3.5#13199
stanislavkozlovski merged 1 commit intoapache:trunkfrom
ijuma:build-dep-update-3.5

Conversation

@ijuma
Copy link
Member

@ijuma ijuma commented Feb 6, 2023 •
edited
Loading

The most recent version that didn't cause compiler or test errors was chosen.

Gradle plugin updates follow, they include minor fixes and support
for newer Java and Gradle versions:

  • spotless: 6.10.0 -> 6.13.0
  • versions: 0.42.0 -> 0.44.0
  • dependencycheck: 7.1.1 -> 8.0.2
  • rat: 0.7.1 -> 0.8.0
  • spotbugs: 5.0.9 -> 5.0.13
  • test-retry: 1.4.0 -> 1.5.1
  • scoverage: 7.0.0 -> 7.0.1

Test/benchmark updates:

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

showuon
showuon reviewed Feb 6, 2023
View reviewed changes
@ijuma ijuma force-pushed the build-dep-update-3.5 branch 3 times, most recently from b8d4f5c to c099371 Compare February 6, 2023 13:00
@ijuma ijuma force-pushed the build-dep-update-3.5 branch from c099371 to 7d5a182 Compare February 6, 2023 13:00
@clolov
Copy link
Contributor

clolov commented Feb 6, 2023

Do we use some tool which suggests these newer versions or we do the checks manually for each release?

@ijuma
Copy link
Member Author

ijuma commented Feb 6, 2023

I used gradlew dependencyUpdates. A tool that automatically retrieved the release notes/changelogs would be useful. That is the more time consuming part vs the version bumps.

@ijuma
Copy link
Member Author

ijuma commented Feb 6, 2023

JDK 11 build passed, the other two had unrelated failures:

Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true 20 sec 1
Build / JDK 8 and Scala 2.12 / kafka.admin.ReassignPartitionsIntegrationTest.testProduceAndConsumeWithReassignmentInProgress(String).quorum=kraft

@ijuma
Copy link
Member Author

ijuma commented Feb 6, 2023

@showuon This is now ready for review.

@dejan2609 dejan2609 mentioned this pull request Feb 6, 2023
Merged
stanislavkozlovski
stanislavkozlovski approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@stanislavkozlovski stanislavkozlovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

showuon
showuon approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Failed tests are unrelated

    Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
    Build / JDK 8 and Scala 2.12 / kafka.admin.ReassignPartitionsIntegrationTest.testProduceAndConsumeWithReassignmentInProgress(String).quorum=kraft

@stanislavkozlovski stanislavkozlovski merged commit 031d0ff into apache:trunk Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanislavkozlovski stanislavkozlovski stanislavkozlovski approved these changes

@showuon showuon showuon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ijuma @clolov @stanislavkozlovski @showuon