KAFKA-17052: Downgrade ShadowJarPlugin to 8.1.3#16489
Merged
omkreddy merged 1 commit intoapache:trunkfrom Jun 29, 2024
Merged
Conversation
Signed-off-by: Greg Harris <[email protected]>
3 tasks
omkreddy
approved these changes
Jun 29, 2024
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@gharris1727 Thanks for the PR. LGTM
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
This version of the ShadowJarPlugin uses the incorrect classifier for the published archive. This is a temporary measure to fix publishing prior to the upcoming release. Signed-off-by: Greg Harris <[email protected]> Reviewers: Manikumar Reddy <[email protected]>
mumrah
pushed a commit
that referenced
this pull request
Mar 12, 2025
**Prologue (related PR's):** - #16295 - #17218 - #16489 **Action points:** - switch shadow plugin from `io.github.goooler.shadow` to `com.gradleup.shadow` - upgrade plugin version from **8.1.3** to **8.3.5** (release notes: https://gradleup.com/shadow/changes/#v8-3-5-2024-11-03) **Rationale:** both previous one and currently used shadow plugins are now deprecated (in favor of `com.gradleup.shadow`): - `com.github.johnrengelman.shadow` maintenance was transferred to `com.gradleup.shadow`: https://github.com/GradleUp/shadow/tree/8.3.5?tab=readme-ov-file#gradle-shadow - `io.github.goooler.shadow`: changes are ported to `com.gradleup.shadow`: https://github.com/Goooler/shadow?tab=readme-ov-file#gradle-shadow **Pitfall (to keep in mind):** - #15532 Co-authored-by: Goooler <[email protected]> Reviewers: Apoorv Mittal <[email protected]>, David Arthur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version of the ShadowJarPlugin uses the incorrect classifier for the published archive. This is a temporary measure to fix publishing prior to the upcoming release.
Committer Checklist (excluded from commit message)