Revert "KAFKA-16803: Change fork, update ShadowJavaPlugin to 8.1.7 (#16295)"#17218
Merged
cmccabe merged 1 commit intoapache:3.9from Sep 17, 2024
Merged
Revert "KAFKA-16803: Change fork, update ShadowJavaPlugin to 8.1.7 (#16295)"#17218cmccabe merged 1 commit intoapache:3.9from
cmccabe merged 1 commit intoapache:3.9from
Conversation
…pache#16295)" This reverts commit 391778b. Unfortunately that commit re-introduced bug apache#15127 which prevented the publishing of kafka-clients artifacts to remote maven. As that bug says: The issue triggers only with publishMavenJavaPublicationToMavenRepository due to signing. Generating signed asc files error out for shadowed release artifacts as the module name (clients) differs from the artifact name (kafka-clients). The fix is basically to explicitly define artifact of shadowJar to signing and publish plugin. project.shadow.component(mavenJava) previously outputs the name as client-<version>-all.jar though the classifier and archivesBaseName are already defined correctly in :clients and shadowJar construction.
dajac
pushed a commit
that referenced
this pull request
Feb 22, 2025
…16295)" (#19000) The PR: #16295 which changed the shadow plugin version has re-introduced the issue with publication of signed jars, fixed in: #15308. This PR reverts #16295 to unblock Kafka 4.0 release. And we should aim for fixing the issue permanently as being discussed here: #18018. Seems same issue was encountered during `Kafka-3.9` release and same commit was reverted in 3.9 as well: #17218. Reviewers: David Jacot <[email protected]>
mumrah
pushed a commit
that referenced
this pull request
Mar 12, 2025
**Prologue (related PR's):** - #16295 - #17218 - #16489 **Action points:** - switch shadow plugin from `io.github.goooler.shadow` to `com.gradleup.shadow` - upgrade plugin version from **8.1.3** to **8.3.5** (release notes: https://gradleup.com/shadow/changes/#v8-3-5-2024-11-03) **Rationale:** both previous one and currently used shadow plugins are now deprecated (in favor of `com.gradleup.shadow`): - `com.github.johnrengelman.shadow` maintenance was transferred to `com.gradleup.shadow`: https://github.com/GradleUp/shadow/tree/8.3.5?tab=readme-ov-file#gradle-shadow - `io.github.goooler.shadow`: changes are ported to `com.gradleup.shadow`: https://github.com/Goooler/shadow?tab=readme-ov-file#gradle-shadow **Pitfall (to keep in mind):** - #15532 Co-authored-by: Goooler <[email protected]> Reviewers: Apoorv Mittal <[email protected]>, David Arthur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "KAFKA-16803: Change fork, update ShadowJavaPlugin to 8.1.7 (#16295)"
This reverts commit 391778b.
Unfortunately that commit re-introduced bug #15127 which prevented the publishing of kafka-clients
artifacts to remote maven. As that bug says: