Skip to content

KAFKA-19809 CheckStyle version upgrade: 10 -->> 12#20726

Merged
chia7712 merged 1 commit intoapache:trunkfrom
dejan2609:KAFKA-19809
Dec 12, 2025
Merged

KAFKA-19809 CheckStyle version upgrade: 10 -->> 12#20726
chia7712 merged 1 commit intoapache:trunkfrom
dejan2609:KAFKA-19809

Conversation

@dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Oct 18, 2025

Jira ticket: KAFKA-19809

Related link: https://checkstyle.org/releasenotes.html#Release_12.2.0

⚠️ quick and dirty (aka skeleton) solution

Reviews are welcome!

Relates to: checkstyle/checkstyle#16003

Reviewers: Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community kraft build Gradle build or GitHub Actions clients group-coordinator small Small PRs labels Oct 18, 2025
<module name="ClassFanOutComplexity">
<!-- default is 20 -->
<property name="max" value="52"/>
<property name="max" value="55"/>
Copy link
Contributor Author

@dejan2609 dejan2609 Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options:

  1. increase limit (like here)
  2. create a baseline (skip/suppress this check for existing cases/classes)
  3. change existing classes and keep the old property value max limit

<suppress checks="ImportControl" files="(JaasTestUtils).java" />

<suppress checks="FinalLocalVariable" files="."/>
<suppress checks="FinalParameters" files="."/>
Copy link
Contributor Author

@dejan2609 dejan2609 Oct 19, 2025

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't pay attention to this PR, but upgrading a dependency should not change any checkstyle rules... We should not have disabled this; inside KS module, we have this rule for a long time, and want to keep it (personally, I would think it would actually be good to even expand its scope to the entire code base, but that's a different discussion, and I don't want to touch it at this point)

Fixing via #21456

\cc @chia7712

@github-actions github-actions bot removed the triage PRs from the community label Oct 20, 2025
@dejan2609
Copy link
Contributor Author

Can you please take a look @chia7712 ?

@dejan2609
Copy link
Contributor Author

It seems that this PR has to be rebased onto trunk (to avoid Could not find build scan errors).

@dejan2609 dejan2609 changed the title KAFKA-19809 CheckStyle version upgrade: 10.20.2 -->> 12.0.1 KAFKA-19809 CheckStyle version upgrade: 10 -->> 12 Nov 12, 2025
<module name="ClassDataAbstractionCoupling">
<!-- default is 7 -->
<property name="max" value="25"/>
<property name="max" value="28"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options:

  1. increase limit (like here)
  2. create a baseline (skip/suppress this check for existing cases/classes)
  3. change existing classes and keep the old property value max limit

@romani
Copy link

romani commented Dec 10, 2025

After this PR is any form is merged, checkstyle team will start using Kafka repository code base in regression testing.
If Kafka team keeps no checkstyle errors strictly enforced, checkstyle team will send PR each time there is additional fixes are required that will be released in in future.

So update of checkstyle version will be just version number bump.

@romani
Copy link

romani commented Dec 11, 2025

@dejan2609 , please resolve conflict.

@romani
Copy link

romani commented Dec 11, 2025

Checkstyle team merged integration of Kafka validation over by checkstyle for each pull request to checkstyle.

Any changes in behavior that results in extra violations on Kafka code base will result in PR from checkstyle team to Kafka to be merged before checkstyle accept PR checkstyle code base.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 89aa87c into apache:trunk Dec 12, 2025
23 checks passed
@dejan2609 dejan2609 deleted the KAFKA-19809 branch December 12, 2025 16:05
shashankhs11 pushed a commit to shashankhs11/kafka that referenced this pull request Dec 15, 2025
Jira ticket: KAFKA-19809

Related link: https://checkstyle.org/releasenotes.html#Release_12.2.0

⚠️   quick and dirty (aka skeleton) solution

Reviews are welcome!

Relates to: checkstyle/checkstyle#16003

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants