KAFKA-2621; nextOffsetMetadata should be changed after rolling a new log segment#286
Closed
lindong28 wants to merge 2 commits intoapache:trunkfrom
Closed
KAFKA-2621; nextOffsetMetadata should be changed after rolling a new log segment#286lindong28 wants to merge 2 commits intoapache:trunkfrom
lindong28 wants to merge 2 commits intoapache:trunkfrom
Conversation
Member
Author
|
@becketqin Could you take a look? |
Contributor
There was a problem hiding this comment.
Maybe we can put this inside the roll()? Right after we add the new segment into the segments list. Because that is the actual place the base offset changes.
Member
Author
There was a problem hiding this comment.
This makes sense to me. I think it is OK to possibly call do updateLogEndOffset() twice in the Log.append(). I have updated patch as you suggested.
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…er/consumer to network client (apache#286) [LI-HOTFX] Allow passing client software name and version from producer/consumer to network client (apache#128) TICKET = N/A LI_DESCRIPTION = Add config to pass customized client name from producer/consumer to ApiVersionsRequest. Starting from kafka 2.4, brokers are able to collect clients' version and name, see KIP-511 for more details. With kafka 2.4 and linkedin-kafka-clients 10, we should make this name unique so that in future when collecting user metrics, we can distinguish supported clients from those using unsupported clients EXIT_CRITERIA = N/A Co-authored-by: Ke Hu <[email protected]> (cherry picked from commit 011ebf8) fixing merge conflicts and tests
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…cer/consumer to network client (apache#286) Original commit: [LI-HOTFX] Allow passing client software name and version from producer/consumer to network client (apache#128) TICKET = N/A LI_DESCRIPTION = Add config to pass customized client name from producer/consumer to ApiVersionsRequest. Starting from kafka 2.4, brokers are able to collect clients' version and name, see KIP-511 for more details. With kafka 2.4 and linkedin-kafka-clients 10, we should make this name unique so that in future when collecting user metrics, we can distinguish supported clients from those using unsupported clients EXIT_CRITERIA = N/A Co-authored-by: Ke Hu <[email protected]> (cherry picked from commit 011ebf8) fixing merge conflicts and tests
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…cer/consumer to network client (apache#286) Original commit: [LI-HOTFX] Allow passing client software name and version from producer/consumer to network client (apache#128) TICKET = N/A LI_DESCRIPTION = Add config to pass customized client name from producer/consumer to ApiVersionsRequest. Starting from kafka 2.4, brokers are able to collect clients' version and name, see KIP-511 for more details. With kafka 2.4 and linkedin-kafka-clients 10, we should make this name unique so that in future when collecting user metrics, we can distinguish supported clients from those using unsupported clients EXIT_CRITERIA = N/A Co-authored-by: Ke Hu <[email protected]> (cherry picked from commit 011ebf8) fixing merge conflicts and tests
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.