MINOR: Add spotlessScalaCheck dependency to streams-scala test task#5479
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Aug 13, 2018
Merged
MINOR: Add spotlessScalaCheck dependency to streams-scala test task#5479guozhangwang merged 1 commit intoapache:trunkfrom
guozhangwang merged 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
@guozhangwang added spotlessScalaCheck dependency to streams-scala test task, so that developers will get format errors while executing streams scala tests. |
Contributor
Author
|
@guozhangwang Pls take a look at this minor PR. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…pache#5479) Reviewers: Guozhang Wang <[email protected]>
ijuma
pushed a commit
that referenced
this pull request
Feb 24, 2023
Details: * gradle upgrade: 7.6 -> 8.0.1 * spotbugs plugin upgrade: 5.0.9 -> 5.0.13 * tweaked the mechanics for `-release`/`-source`/`-target` to workaround idiosyncrasies in Gradle 8.0.1 and newer Scala 2.13 versions. * streams-scala `test` task no longer triggers the `spotless` task since a newer version is required for Gradle 8 support, but the newer version requires Java 11. Note: relates to #5479 Gradle upgrade highlights: * "Scala Incremental Compilation for Multi-Module projects broken in 7.x": gradle/gradle#20101 * "Incremental compilation of java modules is broken with Gradle 7.6": gradle/gradle#23067 Full release notes: https://docs.gradle.org/8.0/release-notes.html Reviewers: Ismael Juma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)