Skip to content

KAFKA-8932; Add tag for CreateTopicsResponse.TopicConfigErrorCode#7464

Merged
rajinisivaram merged 1 commit intoapache:trunkfrom
rajinisivaram:KAFKA-8932-createtopics-tag
Oct 9, 2019
Merged

KAFKA-8932; Add tag for CreateTopicsResponse.TopicConfigErrorCode#7464
rajinisivaram merged 1 commit intoapache:trunkfrom
rajinisivaram:KAFKA-8932-createtopics-tag

Conversation

@rajinisivaram
Copy link
Contributor

This was discussed under KIP-525, but tag was not added in the original commit since the PR with flexible versions hadn't yet been merged. Sets CreateTopics version to 5 with both KIP-525 and flexible versions change so that tags can be used with v5.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rajinisivaram rajinisivaram requested a review from omkreddy October 8, 2019 09:23
Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajinisivaram Thanks for the PR. LGTM.

@rajinisivaram
Copy link
Contributor Author

@omkreddy Thanks for the review, merging to trunk and 2.4

@rajinisivaram rajinisivaram merged commit 1f1179e into apache:trunk Oct 9, 2019
rajinisivaram added a commit that referenced this pull request Oct 9, 2019
ijuma added a commit to ijuma/kafka that referenced this pull request Apr 28, 2020
…t-for-generated-requests

* apache-github/trunk:
  KAFKA-8932; Add tag for CreateTopicsResponse.TopicConfigErrorCode (KIP-525) (apache#7464)
  KAFKA-8944: Fixed KTable compiler warning. (apache#7393)
  KAFKA-8964: Rename tag client-id for thread-level metrics and below (apache#7429)
  MINOR: remove unused imports in Streams system tests (apache#7468)
  KAFKA-7190; Retain producer state until transactionalIdExpiration time passes (apache#7388)
  KAFKA-8983; AdminClient deleteRecords should not fail all partitions unnecessarily (apache#7449)
  MINOR: Modified Exception handling for KIP-470 (apache#7461)
  KAFKA-7245: Deprecate WindowStore#put(key, value) (apache#7105)
  KAFKA-8179: Part 7, cooperative rebalancing in Streams (apache#7386)
  KAFKA-8985; Add flexible version support to inter-broker APIs (apache#7453)
  MINOR: Bump version to 2.5.0-SNAPSHOT (apache#7455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants