MINOR: auto.offset.reset docs not in sync with validation#91
MINOR: auto.offset.reset docs not in sync with validation#91sslavic wants to merge 1 commit intoapache:trunkfrom
Conversation
|
kafka-trunk-git-pr #28 FAILURE |
|
Build is unstable, tests failing, but not due to this PR. |
|
+1 |
|
LGTM @sslavic, not sure why but it seems like the flaky tests don't like your documentation updates. :) The tests have been passing for other PRs with actual code changes. |
|
@ijuma thanks for reviewing my patches. Projects have different rules, what about Apache Kafka - is it a must to have a JIRA ticket for every commit? Am I supposed to create a JIRA ticket along with PR? Would it just speed up accepting of changes? |
|
@sslavic The official documentation on contributing is here http://kafka.apache.org/contributing.html . A separate question is how to speed up the process of integrating changes. Many of the current committers only monitor JIRA at this point since that's still the official way. |
sslavic
changed the title
sslavic
changed the title
In this commit apache@0699ff2#diff-5533ddc72176acd1c32f5abbe94aa672 among other things auto.offset.reset possible options were changed from smallest to earliest and from largest to latest, but not in documentation for that configuration property. This patch fixes documentation for auto.offset.reset consumer configuration property so it is in sync with validation logic.
|
kafka-trunk-git-pr #64 FAILURE |
|
kafka-trunk-git-pr #66 FAILURE |
|
LGTM. |
…reams-tech-preview Backport recent changes from trunk/streams: batch apache#2
…e#12796) (apache#91) This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until apache#12790. Reviewers: José Armando García Sancio <[email protected]> Co-authored-by: Jason Gustafson <[email protected]>
Clean up localstack setup left. Local executions use MinIO now.
5 participants
In this commit 0699ff2#diff-5533ddc72176acd1c32f5abbe94aa672 among other things auto.offset.reset possible options were changed from smallest to earliest and from largest to latest, but not in documentation for that configuration property.
This patch fixes documentation for auto.offset.reset consumer configuration property so it is in sync with validation logic.