Conversation
Contributor
this issues does not exist |
Bukama
reviewed
Jul 20, 2025
Contributor
Bukama
left a comment
There was a problem hiding this comment.
I have no strong opinion about this, but why change the more detailed error message to a general one which then can't be linked to a unique position in code?
Fixing the grammar mistakes if ofc good :)
Contributor
Author
|
Because the more detailed message was confusing users/readers. Model version and maven version are confusingly intertwined. |
|
@elharo Please assign appropriate label to PR according to the type of change. |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 21, 2025
Resolved conflicts by accepting deletion of documentation files that were moved/reorganized in master: - src/site/markdown/configuration.properties - src/site/markdown/configuration.yaml - src/site/markdown/maven-configuration.md These files were moved to src/configuration-templates/ in master. Merged changes include: - Fix doap_Maven.rdf - Add PathMatcherFactory.includesAll() (apache#10964) - Generating configuration documentation during site build (apache#10961) - Use correct namespace in settings.xml (apache#10974) - Make error message less awkward (apache#10953) All plugin migration changes preserved and compatible with latest master.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 23, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase. Key Changes: - Removed all AssertJ dependencies from pom.xml files - Converted all assertThat() calls to JUnit 5 equivalents - Enhanced 632+ assertions with meaningful error messages - Fixed test logic issues in DefaultPluginXmlFactoryTest Migration Patterns: - assertThat().isEqualTo() → assertEquals() with context - assertThat().contains() → assertTrue(string.contains()) with details - assertThat().isInstanceOf() → assertInstanceOf() with descriptions - assertThat().matches() → assertTrue(string.matches()) with patterns - assertThat().isNull() → assertNull() with meaningful messages Results: - ✅ Complete removal of AssertJ dependency - ✅ Full project compilation success (39/39 modules) - ✅ 99.6% test success rate (506/508 tests passing) - ✅ Enhanced debugging experience with meaningful assertion messages - ✅ Consistent assertion patterns across entire codebase The 2 remaining test failures are unrelated environment-specific path encoding issues. Fixes: apache#10953
gnodet
pushed a commit
to gnodet/maven
that referenced
this pull request
Jul 24, 2025
* Make error message less awkward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10891