Skip to content

Make error message less awkward#10953

Merged
elharo merged 3 commits intomasterfrom
10891
Jul 21, 2025
Merged

Make error message less awkward#10953
elharo merged 3 commits intomasterfrom
10891

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jul 19, 2025

fixes #10891

@Bukama
Copy link
Contributor

Bukama commented Jul 19, 2025

fixes #10981

this issues does not exist

@elharo elharo marked this pull request as ready for review July 19, 2025 17:01
@elharo elharo requested a review from Bukama July 19, 2025 17:02
Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion about this, but why change the more detailed error message to a general one which then can't be linked to a unique position in code?

Fixing the grammar mistakes if ofc good :)

@elharo
Copy link
Contributor Author

elharo commented Jul 20, 2025

Because the more detailed message was confusing users/readers. Model version and maven version are confusingly intertwined.

@elharo elharo merged commit 023374d into master Jul 21, 2025
21 checks passed
@elharo elharo deleted the 10891 branch July 21, 2025 10:33
@github-actions
Copy link

@elharo Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 4.1.0 milestone Jul 21, 2025
@elharo elharo added skip-changelog Skip this PR from automatically changelog generation bug Something isn't working labels Jul 21, 2025
gnodet added a commit to gnodet/maven that referenced this pull request Jul 21, 2025
Resolved conflicts by accepting deletion of documentation files that were
moved/reorganized in master:
- src/site/markdown/configuration.properties
- src/site/markdown/configuration.yaml
- src/site/markdown/maven-configuration.md

These files were moved to src/configuration-templates/ in master.

Merged changes include:
- Fix doap_Maven.rdf
- Add PathMatcherFactory.includesAll() (apache#10964)
- Generating configuration documentation during site build (apache#10961)
- Use correct namespace in settings.xml (apache#10974)
- Make error message less awkward (apache#10953)

All plugin migration changes preserved and compatible with latest master.
gnodet added a commit to gnodet/maven that referenced this pull request Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet added a commit to gnodet/maven that referenced this pull request Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet added a commit to gnodet/maven that referenced this pull request Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet added a commit to gnodet/maven that referenced this pull request Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet added a commit to gnodet/maven that referenced this pull request Jul 22, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet added a commit to gnodet/maven that referenced this pull request Jul 23, 2025
Complete migration from AssertJ to JUnit 5 assertions across the entire Maven codebase.

Key Changes:
- Removed all AssertJ dependencies from pom.xml files
- Converted all assertThat() calls to JUnit 5 equivalents
- Enhanced 632+ assertions with meaningful error messages
- Fixed test logic issues in DefaultPluginXmlFactoryTest

Migration Patterns:
- assertThat().isEqualTo() → assertEquals() with context
- assertThat().contains() → assertTrue(string.contains()) with details
- assertThat().isInstanceOf() → assertInstanceOf() with descriptions
- assertThat().matches() → assertTrue(string.matches()) with patterns
- assertThat().isNull() → assertNull() with meaningful messages

Results:
- ✅ Complete removal of AssertJ dependency
- ✅ Full project compilation success (39/39 modules)
- ✅ 99.6% test success rate (506/508 tests passing)
- ✅ Enhanced debugging experience with meaningful assertion messages
- ✅ Consistent assertion patterns across entire codebase

The 2 remaining test failures are unrelated environment-specific path encoding issues.

Fixes: apache#10953
gnodet pushed a commit to gnodet/maven that referenced this pull request Jul 24, 2025
* Make error message less awkward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve the wording of the error message for modelVersion mismatch

2 participants