[maven-4.0.x] Prevent infinite loop in RootLocator when .mvn directory exists in subdirectory (fixes #11321) (#11323)#11350
Merged
gnodet merged 2 commits intoapache:maven-4.0.xfrom Oct 29, 2025
Conversation
…bdirectory (fixes apache#11321) (apache#11323) This is a fix that adds validation to prevent reading parent POMs that are located above the discovered root directory. This prevents infinite loops when a .mvn directory exists in a subdirectory and Maven is invoked with -f pointing to that subdirectory. The fix includes: - Validation in doReadFileModel() to check parent POM location - Validation in getEnhancedProperties() to prevent infinite loops - Helper method isParentWithinRootDirectory() for path validation - Integration test to reproduce and verify the fix (cherry picked from commit 714fc51)
The integration test for apacheGH-11321 needs to specify that it only runs on Maven 4.0.0 and later, since the fix is only available in those versions. This prevents the test from running on older Maven versions where the fix is not present, which was causing CI failures. The test validates that Maven properly rejects setups where a parent POM is located above the root directory when a .mvn directory exists in a subdirectory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertomaven-4.0.x:Questions ?
Please refer to the Backport tool documentation