Fix field accessibility leak in EnhancedCompositeBeanHelper#11425
Merged
gnodet merged 2 commits intoapache:masterfrom Nov 12, 2025
Merged
Fix field accessibility leak in EnhancedCompositeBeanHelper#11425gnodet merged 2 commits intoapache:masterfrom
gnodet merged 2 commits intoapache:masterfrom
Conversation
The previous implementation cached field accessibility state globally, which could cause issues when the same field is accessed from different contexts or security managers. This was particularly problematic in plugin unit tests where fields would remain accessible after being set. The fix ensures that field accessibility is properly restored to its original state after setting field values, preventing accessibility state from leaking between different bean instances. Added unit tests to verify: - Field accessibility is restored after setting values - Multiple field accesses don't leak accessibility state - The fix works correctly across different bean instances This resolves the issue reported on the dev list regarding compiler plugin unit test failures related to field accessibility.
cstamas
approved these changes
Nov 10, 2025
desruisseaux
approved these changes
Nov 10, 2025
Contributor
desruisseaux
left a comment
desruisseaux
left a comment
There was a problem hiding this comment.
I verified that together with #11429 and apache/maven-compiler-plugin#991 it allows the JUnit tests and integration tests of the compiler plugin to pass.
| } else if (!isAccessible) { | ||
| boolean wasAccessible = field.canAccess(bean); | ||
| if (!wasAccessible) { | ||
| field.setAccessible(true); |
Contributor
There was a problem hiding this comment.
This code assumes that the same Field object will not be set by two threads in same time. It seems to imply that EnhancedCompositeBeanHelper is not really thread-safe. If this limitation okay?
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll remove the setAccessible(false), as once the field has been made accessible, there's no real need to un-expose it.
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 12, 2025
…1425) The previous implementation cached field accessibility state globally, which could cause issues when the same field is accessed from different contexts or security managers. This was particularly problematic in plugin unit tests where fields would remain accessible after being set. The fix ensures that field accessibility is properly restored to its original state after setting field values, preventing accessibility state from leaking between different bean instances. Added unit tests to verify: - Field accessibility is restored after setting values - Multiple field accesses don't leak accessibility state - The fix works correctly across different bean instances This resolves the issue reported on the dev list regarding compiler plugin unit test failures related to field accessibility. (cherry picked from commit 6e30ae6)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Nov 13, 2025
…11433) The previous implementation cached field accessibility state globally, which could cause issues when the same field is accessed from different contexts or security managers. This was particularly problematic in plugin unit tests where fields would remain accessible after being set. The fix ensures that field accessibility is properly restored to its original state after setting field values, preventing accessibility state from leaking between different bean instances. Added unit tests to verify: - Field accessibility is restored after setting values - Multiple field accesses don't leak accessibility state - The fix works correctly across different bean instances This resolves the issue reported on the dev list regarding compiler plugin unit test failures related to field accessibility. (cherry picked from commit 6e30ae6)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation cached field accessibility state globally, which could cause issues when the same field is accessed from different contexts or security managers. This was particularly problematic in plugin unit tests where fields would remain accessible after being set.
The fix ensures that field accessibility is properly restored to its original state after setting field values, preventing accessibility state from leaking between different bean instances.
Added unit tests to verify:
This resolves the issue reported on the dev list regarding compiler plugin unit test failures related to field accessibility.