[MNG-8376] Exit with a nicer error message when running on JDK < 17#1916
Merged
gnodet merged 4 commits intoapache:masterfrom Nov 18, 2024
Merged
[MNG-8376] Exit with a nicer error message when running on JDK < 17#1916gnodet merged 4 commits intoapache:masterfrom
gnodet merged 4 commits intoapache:masterfrom
Conversation
Member
Why not, sounds reasonable...via toolchains? |
elharo
approved these changes
Nov 17, 2024
Member
|
We assume thet user have awk .... public class CheckJavaVersion {
public static void main(String[] args) {
if (Double.parseDouble(System.getProperty("java.vm.specification.version")) < 17.0) {
System.exit(2);
}
}
}compile with target 8, put in bin directory it will be easy to execute and check statu code of execution |
Contributor
Author
I just changed the script to simply rely on java to verify that the argument can be used. |
slawekjaranowski
approved these changes
Nov 17, 2024
cstamas
approved these changes
Nov 18, 2024
|
Resolve #9477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be tested on windows, or maybe just add an IT ?