[MNG-8385] Introduce proto session#1929
Merged
cstamas merged 10 commits intoapache:masterfrom Nov 20, 2024
Merged
Conversation
And make use of it in CLIng. Also, move from "late" Resolver session factory to "early" CLIng invocation of PropertyContributors and make their contribution visible in whole Maven, not only Resolver.
As in case of loading extensions, the context lookup is not yet there.
gnodet
reviewed
Nov 20, 2024
...rces/mng-8385/spi-extension/src/main/resources/META-INF/maven/org.apache.maven.api.di.Inject
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Nov 20, 2024
its/core-it-suite/src/test/resources/mng-8385/spi-extension/.mvn/placeholder.txt
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Nov 20, 2024
| * @see #contribute(ProtoSession) | ||
| */ | ||
| void contribute(Map<String, String> userProperties); | ||
| default void contribute(Map<String, String> userProperties) {} |
Contributor
There was a problem hiding this comment.
Glad we keep compatibility somehow !
gnodet
reviewed
Nov 20, 2024
| import org.apache.maven.api.spi.PropertyContributor; | ||
|
|
||
| /** | ||
| * Hack: to circumvent sisu/plexus/di stuff. |
Contributor
There was a problem hiding this comment.
I really need to investigate what's the problem here.
gnodet
approved these changes
Nov 20, 2024
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM, a few minor enhancements are possible to remove two files from the IT.
Member
Author
|
Dropped two files, locally is ok, let see ITs and merge |
It is and should contribute user properties only.
|
Resolve #9468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make use of it in CLIng. Also, move from "late" Resolver session factory to "early" CLIng invocation of
PropertyContributorSPI and make contribution visible across whole Maven, not only Resolver.https://issues.apache.org/jira/browse/MNG-8385