Merged
Conversation
Now it all depends HOW the context is created.
gnodet
approved these changes
Dec 17, 2024
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Awesome ! Really nice work !
alextu
reviewed
Dec 19, 2024
| .build(); | ||
|
|
||
| customizeSettingsRequest(context, settingsRequest); | ||
| if (context.eventSpyDispatcher != null) { |
There was a problem hiding this comment.
Our regression tests fail because the SettingsBuilderRequest event no longer fires after this PR has been merged. Would that be because eventSpyDispatcher is now somehow null at this point?
Member
Author
There was a problem hiding this comment.
This method is called twice, once (very early) when loading up extensions, then spy is null. The 2nd invocation is when "maven boots" and then spy should not be null...
There was a problem hiding this comment.
Here's a reproducer https://github.com/alextu/maven4-reproducer
|
Resolve #9418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beginning
https://asciinema.org/a/KxFoz2NUyI0joa4kM4ZRRCJgD
Changes:
-o(offline) option to "generic" Options from MavenOptionsRelated PRs:
https://issues.apache.org/jira/browse/MNG-8437