Conversation
| <code>central</code> or <code>*,!repo1</code>. | ||
| <code>*</code> (since Maven 2.0.5), <code>external:*</code> (since Maven 2.0.9) and <code>external:http:*</code> (since Maven 3.8.0) have | ||
| <code>*</code>, <code>external:*</code> and <code>external:http:*</code> (since Maven 3.8.0) have | ||
| a special meaning: see <a href="/guides/mini/guide-mirror-settings.html">Mirror Settings</a> guide. |
There was a problem hiding this comment.
Would it make sense to move the documentation in the code rather than keeping it external ?
It's easier to maintain as using a single PR allows updating both the code and the doc.
There was a problem hiding this comment.
I'm not sure what you're proposing here.
There was a problem hiding this comment.
My suggestion was to inline the content of https://maven.apache.org/guides/mini/guide-mirror-settings.html into the model, so that the generated javadoc for the Mirror class will contain the documentation.
There was a problem hiding this comment.
I wouldn't prefer that. guide-mirror-settings.html is written for people who simply use Maven for their own projects and might never look at the API docs.
There was a problem hiding this comment.
Agreed. My point was to move the documentation inside the code base along the source code.
It could be put in https://github.com/apache/maven/tree/master/src/site rather than in an unversioned area from a different git repository.
There was a problem hiding this comment.
Maybe then. I'm not sure how maven site is published and what parts come from where.
There was a problem hiding this comment.
Since we remove references to old version, what's the point of keeping the ref for Maven 3.8.0 ?
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
I've seen a few other "Maven 2" references in the main model.
Would it make sense to change them as well ?
https://github.com/apache/maven/blob/master/api/maven-api-model/src/main/mdo/maven.mdo
|
Yes to remove other references, but that's for another PR. This bug has already seen dozens of PRs and may require dozens more before it;'s done. |
|
Looks like those changes are already out for review in #2023 |
2 participants
No description provided.