Skip to content

[MNG-8561] SourceRoot should be more lenient wrt duplicates#2085

Merged
gnodet merged 5 commits intoapache:masterfrom
gnodet:MNG-8561
Feb 6, 2025
Merged

[MNG-8561] SourceRoot should be more lenient wrt duplicates#2085
gnodet merged 5 commits intoapache:masterfrom
gnodet:MNG-8561

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 5, 2025

Add includes/excludes to the SourceKey

JIRA issue: MNG-8561

@gnodet gnodet requested a review from desruisseaux February 5, 2025 08:18
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

@desruisseaux
Copy link
Contributor

We could also remove this SourceKey stuff completely. The intend was to prevent ambiguous situations or potential mistakes such as declaring the same sources for two Java releases. But those checks are superficial anyway.

@gnodet
Copy link
Contributor Author

gnodet commented Feb 5, 2025

I've added support for wrapping the <resources> and <testResources>, remove the SourceKey completely to restore previous behavior and added an IT.

@gnodet gnodet requested a review from elharo February 5, 2025 17:46
@gnodet gnodet requested a review from elharo February 5, 2025 22:45
@gnodet gnodet added this to the 4.0.0-rc-3 milestone Feb 6, 2025
@gnodet gnodet merged commit 34e68c8 into apache:master Feb 6, 2025
13 checks passed
@jira-importer
Copy link

Resolve #9886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants