Merged
Conversation
And move the OS static helper to util, is not profile specific. --- https://issues.apache.org/jira/browse/MNG-8573
pzygielo
reviewed
Feb 10, 2025
| String family(); | ||
|
|
||
| /** | ||
| * Returns {@code true} if you need to make extra hoops and loops. |
Contributor
There was a problem hiding this comment.
I hope this javadoc could be reworded.
Member
Author
There was a problem hiding this comment.
sure, am just testing our reviewers "eagle eye"
elharo
reviewed
Feb 10, 2025
Contributor
elharo
left a comment
There was a problem hiding this comment.
I don't see why we need a wrapper around the utility class. This feels like added complexity for no special purpose.
Member
Author
|
The goal is simple:
|
Contributor
|
I've enhanced the javadoc, but I wonder if it would make more sense to use proper enums, as we don't even define the values. |
Member
Author
|
Yes, I intentionally left them out, as IMO this service would be most used for things like:
I just wanted to keep this OS stuff small, minimal. And once service, we can later extend it with new methods, as required or we spot some need. |
|
Resolve #9877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move the OS static helper to util, is not
profile specific.
https://issues.apache.org/jira/browse/MNG-8573