[MNG-8614] Maven Sisu in Maven 4 same as in Maven 3#2284
Merged
cstamas merged 1 commit intoapache:masterfrom May 5, 2025
Merged
[MNG-8614] Maven Sisu in Maven 4 same as in Maven 3#2284cstamas merged 1 commit intoapache:masterfrom
cstamas merged 1 commit intoapache:masterfrom
Conversation
The Sisu "strict" flag has issues, but also, it is best and simplest to help transitioning by making Sisu in Maven 4 behave in very same way as it behaves in Maven 3. --- https://issues.apache.org/jira/browse/MNG-8614
Member
|
Can't we fix the underlying issue in sisu rather? I am still convinced that throwing exceptions at least for incompatible bytecode is the right thing to do.... |
Member
Author
|
Even if we fix the issue, my point is to ease transition from Maven 3 to Maven 4, having Sisu behaving the same in both is just better, makes things simpler. |
Member
Author
|
We can fix Sisu and make it strict in 4.1 or alike. I find this change (enabling strict) a bit disrupting for 4.0 that should allow easy transition from 3.x Maven. |
slawekjaranowski
approved these changes
May 4, 2025
elharo
approved these changes
May 5, 2025
|
Resolve #9835 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sisu "strict" flag has issues, but also, it is best and simplest to help transitioning by making Sisu in Maven 4 behave in very same way as it behaves in Maven 3.
https://issues.apache.org/jira/browse/MNG-8614