Ban "plain" Guice; downgrade it to 5.1.0#2472
Merged
cstamas merged 3 commits intoapache:masterfrom Jun 11, 2025
Merged
Conversation
We use the one with "classes" classifier. Clean up dependencies as well as we had both, plus we had popping up via some test deps as well. Ban the "plain" JAR as well, to make sure we have only the proper ASM-less one here.
gnodet
approved these changes
Jun 11, 2025
Member
|
In general ok, but what to do with external components that may be injected? Keep it in javax.inject? |
Member
Author
|
jakarta package name was never exported from maven core, but it was present in core. so nothing was able to use it anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current master uses Guice 6 and this has following consequences:
/libof Maven distro: it is a transitive dep of Guice 6javax.inject, Maven JSR330 is here only for Maven 3 backward compatibility, while "native" Maven 4 stuff has Maven DI in place. Best to keep it aligned with Maven 3.9.x line.Changes: