Move project mutation inside project lock#2474
Merged
gnodet merged 1 commit intoapache:masterfrom Jun 12, 2025
Merged
Conversation
This is just a forward port of bugfix from 3.9.x Fixed apache#2455
gnodet
reviewed
Jun 12, 2025
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
We need a descriptive commit message, not only a reference to the other fix.
cstamas
changed the title
cstamas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move method into lock scope as it is mutating MavenProject instance.
This ensures that instance mutation happens by single caller.
Fixes #2455