Conversation
asfgit
force-pushed
the
MNG-7571
branch
4 times, most recently
from
a4b5f92 to
522f7a4
Compare
asfgit
force-pushed
the
MNG-7571
branch
2 times, most recently
from
f565ba3 to
5afe135
Compare
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Mostly stylistic issues.
An general issue on separation: <name>Maven 4 API - Toolchain</name>
Stylistically a hyphen is the wrong symbol. It should be an en dash in this case, but many of our components use ::. See Doxia, Wagon, Core ITs, Indexer. So I would make it consistent here: ::
|
|
||
| <artifactId>maven-api-meta</artifactId> | ||
| <name>Maven API Meta annotations</name> | ||
| <name>Maven 4 API Meta annotations</name> |
There was a problem hiding this comment.
should we rename the artifactId?
There was a problem hiding this comment.
Yes, good idea: maven-api-meta-annotations?
| <artifactId>plexus-utils</artifactId> | ||
| <version>4.0.0-alpha-4-SNAPSHOT</version> | ||
| <name>Apache Maven Plexus-Utils</name> | ||
| <description>Apache Maven repackaging of Plexus Utils with immutable Dom interface and its replacement implementation.</description> |
There was a problem hiding this comment.
no, the interface is named Dom, which is not the best name IMHO...
There was a problem hiding this comment.
Really? This is confusing, it thought it is an acronym referring to Document Object Model...
There was a problem hiding this comment.
The name comes from the plexus class Xpp3Dom but I removed the Xpp3 part. And yes, it's referring to Document Object Model, but I would not call it DOM. We could rename it XmlNode ?
|
I'll merge this PR regarding basic documentation improvements on the renaming ideas ( |
|
Resolve #8881 |
4 participants
https://issues.apache.org/jira/browse/MNG-7571
generated site with this PR:
https://maven.apache.org/ref/4-LATEST/maven-api/maven-api-settings/index.html
https://maven.apache.org/ref/4-LATEST/maven-api/maven-api-model/index.html
https://maven.apache.org/ref/4-LATEST/maven-settings/index.html
https://maven.apache.org/ref/4-LATEST/maven-model/index.html