uh, I'm surprised that commit 38fc24b creates an IT failure...

next steps:

• create a parameter for enabling location tracking in common.vm https://github.com/apache/maven/blob/master/maven-model/src/main/mdo/common.vm
• create a parameter for Properties vs HashMap

at this stage:

• only 2 templates have different content for maven-model vs other modules: model-v3.vm and reader.vm
• still need a flexible way to store the template in one unique location and have Velocity load from there without being blocked by TEMPLATE_ROOT https://velocity.apache.org/engine/1.7/user-guide.html#parse : we'll probably need to add a parameter for https://github.com/codehaus-plexus/modello/blob/master/modello-plugins/modello-plugin-velocity/src/main/java/org/codehaus/modello/plugin/velocity/VelocityGenerator.java#L64

here it is: everything is shared in root module
it requires a small update in Modello: codehaus-plexus/modello#292

the 2 specific generator Velocity templates are named model-v3-modified.vm and reader-modified.vm, waiting for work to reintegrate modification in original templates

Wouldn't be shared resources module better than ${basedir}/.. magic?

What would be the benefit of creating an additional module and publishing the artifact if it's purely internal ?
Also, I think the fact that velocity templates are used means that the templates need to be on the filesystem, which means extracting them before running modello. That sounds a bit complicated imho...

Wouldn't be shared resources module better than ${basedir}/.. magic?

What would be the benefit of creating an additional module and publishing the artifact if it's purely internal ? Also, I think the fact that velocity templates are used means that the templates need to be on the filesystem, which means extracting them before running modello. That sounds a bit complicated imho...

First of all, the deployment can be skipped. I remember that in this exact situation we recommend users to share a module in reactor instead of dealing with path traversal. Of course, it is a bit more work. The result is the same. I will leave the decision to @hboutemy .

thinking again at Modello Velocity Plugin, instead of magically reusing existing basedir parameter, probably creating a new dedicated velocityBasedir directory could make things more clear
and this could even differentiate basedir for .mdo from basedir for .vm, then have better sharing strategies for each (.vm in root, but .mdo in modules even if also loaded from another module)
I'll test that tonight

done: I'm now happy with the result:

• .mdo files stay at their original location, reuse from the 3 api-oriented ones is done without attach but direct access
• .vm files are used directly from root src/mdo directory

last review before I work on doing the Modello 2.1.1 release that includes necessary changes then I can merge this PR

Resolve #8788