Skip to content

[MCLEAN-127] Use Files.createSymbolicLink instead of shelling out#65

Merged
elharo merged 10 commits intomasterfrom
MCLEAN-127
Jan 19, 2025
Merged

[MCLEAN-127] Use Files.createSymbolicLink instead of shelling out#65
elharo merged 10 commits intomasterfrom
MCLEAN-127

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Nov 14, 2024

No description provided.

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2024

Caused by: org.apache.maven.plugin.PluginIncompatibleException: The plugin org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-2-SNAPSHOT has unmet prerequisites: Required Maven version 4.0.0-beta-5 is not met by current version 4.0.0-beta-3

@cstamas
Copy link
Member

cstamas commented Nov 14, 2024

No, but:

[INFO] Build Summary:
[INFO]   Passed: 9, Failed: 2, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
Error:  The following builds failed:
Error:  *  symlink-dont-follow/pom.xml
Error:  *  dangling-symlinks/pom.xml

GH Actions should be observed, the Jenkins instance is not setup (yet?)
If you want to change maven3 plugin, use the branch https://github.com/apache/maven-clean-plugin/tree/maven-clean-plugin-3.x

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2024

Yes, those two failing tests are weird. It looks like Beanshell is having trouble matching the argument types and is looking for a method that matches the actual type rather than the interface supertype.

@elharo
Copy link
Contributor Author

elharo commented Nov 16, 2024

Failures now appear to be in the CI script:

plugin:4.0.0-beta-2-SNAPSHOT:clean (default-clean) on project exclude-default-dirs: The plugin org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-2-SNAPSHOT has unmet prerequisites: Required Maven version 4.0.0-beta-5 is not met by current version 4.0.0-beta-3

@elharo elharo marked this pull request as ready for review November 16, 2024 19:05
@elharo elharo changed the title Use Files.createSymbolicLink instead of shelling out [MCLEAN-127] Use Files.createSymbolicLink instead of shelling out Jan 16, 2025
@elharo elharo requested a review from cstamas January 16, 2025 16:31
@slachiewicz slachiewicz added the enhancement New feature or request label Jan 19, 2025
@elharo elharo merged commit f79f1e4 into master Jan 19, 2025
@elharo elharo deleted the MCLEAN-127 branch January 19, 2025 18:13
@slawekjaranowski slawekjaranowski added this to the 4.0.0-beta-2 milestone Jan 29, 2025
@jira-importer
Copy link

Resolve #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants