[MDEP-82] - resolve plugin dependencies#130
Closed
berlam wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
|
Hi! Is there any updates to this? I see a few recent comments on MDEP-82.. Thanks! |
elharo
reviewed
Oct 13, 2024
| * @since 2.0 | ||
| */ | ||
| @Mojo( name = "resolve-plugins", defaultPhase = LifecyclePhase.GENERATE_SOURCES, threadSafe = true ) | ||
| //CHECKSTYLE_OFF: LineLength |
elharo
requested changes
Oct 13, 2024
Contributor
elharo
left a comment
There was a problem hiding this comment.
This needs a test demonstrating that the bug is fixed
|
Resolve #625 |
Member
|
suppressed by: @berlam thanks for efforts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve plugins with Maven 3.6.3 does currently (master a0ac6fe) not resolve explicit plugin dependencies.
With the POM below the artifact
surefire-junit47will not be downloaded. After the change, it is downloaded as expected.This especially affects
dependency:go-offlineand its usage inside CI pipelines as stated in MDEP-82.I am not sure, how to test that properly using the current state of testing inside that plugin and would appreciate help in doing that. I would like to execute the Resolve-Plugin Mojo but did not get that to work.
I am not sure, if this is the perfect solution, but it is borrowed from an other working maven plugin:
https://github.com/qaware/go-offline-maven-plugin/blob/baa674897d3527a32bc781a54cff97dc0f1b4e4e/src/main/java/de/qaware/maven/plugin/offline/DependencyDownloader.java#L247.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.