Conversation
...main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Jun 9, 2024
slawekjaranowski
approved these changes
Jun 9, 2024
…e-sources This closes #411
slawekjaranowski
approved these changes
Jun 9, 2024
jglick
reviewed
Sep 10, 2024
| * | ||
| * @author <a href="mailto:[email protected]">Brian Fox</a> | ||
| * @since 2.0-alpha2 | ||
| * @deprecated in favor of {@code resolve-sources} goal and will be removed in a future version |
There was a problem hiding this comment.
This message fails to explain that the goals are functionally identical, differing only in name. I looked through the plugin site and FAQ trying to find some explanation of why I should switch and what parameters I would need to change, finally coming across this PR via code archaeology.
Member
Author
There was a problem hiding this comment.
What difference does it make for that matter?
There was a problem hiding this comment.
I am just pointing out that when as a Maven user you see this warning in your build, you may spend time trying to figure out what all you need to do in order to migrate to the new goal, when in fact you need do nothing beyond add resolve- to your command.
|
Resolve #1443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-sources
This closes #411
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MDEP-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.