[MSHARED-1330] Always overwrite files#97
Merged
gnodet merged 5 commits intoapache:masterfrom Mar 2, 2024
Merged
Conversation
elharo
reviewed
Feb 26, 2024
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
why do you need to set the execute bit?
Contributor
Author
We don't, we just need it to be readable and writable, I'll remove that line. |
Contributor
Author
Fixed |
cstamas
approved these changes
Feb 26, 2024
elharo
requested changes
Feb 27, 2024
src/main/java/org/apache/maven/shared/filtering/FilteringUtils.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Feb 27, 2024
src/main/java/org/apache/maven/shared/filtering/FilteringUtils.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Feb 29, 2024
elharo
approved these changes
Feb 29, 2024
|
Resolve #260 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the files are made writable before copying them. The attributes are always restored after the copy.