Remove checkstyle.violation.ignore#183
Merged
slawekjaranowski merged 1 commit intomasterfrom Jun 12, 2024
Merged
Conversation
Member
Author
|
Connected with https://issues.apache.org/jira/browse/MSHARED-1401 |
Member
Author
|
Even more looks like by this property violation is only removed from checking but still exist in site report When we use |
slachiewicz
approved these changes
Jun 8, 2024
CrazyHZM
approved these changes
Jun 8, 2024
slawekjaranowski
force-pushed
the
rm-checkstyle-ignore
branch
from
70aad53 to
2901779
Compare
Ignore rules should be defined by project, class, method ... or we should drop a rule from configuration at all. Ignored rules are still present in checkstyle report.
slawekjaranowski
added
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore rules should be defined by project, class, method ... or we should drop a rule from configuration at all.
Ignored rules are still present in checkstyle report.