Skip to content

[MNG-8453] Check dependency declarations by default#220

Merged
elharo merged 5 commits intomasterfrom
deps
Dec 20, 2024
Merged

[MNG-8453] Check dependency declarations by default#220
elharo merged 5 commits intomasterfrom
deps

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Dec 19, 2024

No description provided.

@elharo elharo requested a review from slachiewicz December 19, 2024 21:21
@elharo elharo changed the title Check dependency declarations by default [MNG-8453] Check dependency declarations by default Dec 19, 2024
</goals>
<configuration>
<failOnWarning>${enforce.dependency.declarations}</failOnWarning>
<ignoredDependencies>org.apache.maven:maven-compat:*,org.slf4j:slf4j-simple:*</ignoredDependencies>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be as separate item for each ignore artifact to allow append more in child project
ignoredDependencies is a list parameter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good ideas, done

@elharo elharo marked this pull request as ready for review December 20, 2024 09:50
@slawekjaranowski
Copy link
Member

for this repo we no need an jira issue ... simply add label and Milestone - release notes will be generate

@elharo elharo added the dependencies Pull requests that update a dependency file label Dec 20, 2024
@elharo elharo added this to the MAVEN-44 milestone Dec 20, 2024
@elharo elharo merged commit 6e1dca0 into master Dec 20, 2024
@elharo elharo deleted the deps branch December 20, 2024 21:46
elharo added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants