Conversation
|
Note: with Maven 4.0.0-rc-3, the tests of the Maven compiler plugin fail with the following stack trace: I do not know how Mockito works (I do not use it myself), but I suspect that the following method of The current implementation seems to define the behaviour of |
|
I don't think it's really a good idea to use the session stub anyway. There's too much needed and a simple stub will almost never work. We can check, but I don't think any plugins we've migrated uses it. So maybe remove it. Empty lists are fine for project and artifact stubs imho. Or use a fields and a setter to make those easier to use, that may be more reusable. |
|
I can remove the JUnit tests of |
…ded in `ProjectStub`. No setter added for `SessionStub` because the previously existing methods were already returning null or empty collections.
…s)` mock. It resolves the `NullPointerException` observed during compiler plugin tests.
|
Added setter methods for usability. Also added an empty stub for |
|
It would be good to modify gha to run tests also with Maven 4. So far all compilation and tests where under Maven 3. |
Upgrade from Maven 4.0.0-rc-2 to 4.0.0-rc-3. There is some new methods in interfaces, which have been implemented as
return List.of(). I'm not sure that returning unconditionally an empty list is the desired behaviour. If not, this pull request may need to be discarded.