Bug: depMgt in manager was "last wins" instead of "first wins"#1702
Merged
cstamas merged 1 commit intoapache:masterfrom Dec 9, 2025
Merged
Bug: depMgt in manager was "last wins" instead of "first wins"#1702cstamas merged 1 commit intoapache:masterfrom
cstamas merged 1 commit intoapache:masterfrom
Conversation
The dependency manager since commit 51a3de6 (2.0.1+) had a bug to detect just added entries, and it resulted in "last wins" logic.
slawekjaranowski
approved these changes
Dec 9, 2025
gnodet
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency manager since commit 51a3de6 (2.0.11+) had a bug to detect just added entries, and it resulted in "last wins" logic.
This PR fixes the issue and adds UT ensuring "first wins".
Still, we are uncovered in tests (seems we are biased), as we have no "duplicate entries in depMgt"-like tests as all!