Skip to content

Enhance RRF#1709

Merged
cstamas merged 4 commits intoapache:masterfrom
cstamas:enhance-rrf
Dec 11, 2025
Merged

Enhance RRF#1709
cstamas merged 4 commits intoapache:masterfrom
cstamas:enhance-rrf

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Dec 11, 2025

Changes:

  • prefix: introduce "resolvePrefixFiles" config that controls auto-discovery (def: true; as before)
  • both: introduce "noInputOutcome" config that controls filtering outcome when enabled but no input provided (def: true; as before)
  • both: cleanup of configuration and use of helper classes

Changes:
* prefix: introduce "resolvePrefixFiles" config that controls auto-discovery (def: true)
* both: introduce "noInputOutcome" config that controls filtering outcome when no input provided (def: true)
* both: cleanup of configuration and use of helper classes
@cstamas cstamas added this to the 2.0.14 milestone Dec 11, 2025
@cstamas cstamas self-assigned this Dec 11, 2025
@cstamas cstamas added the enhancement New feature or request label Dec 11, 2025
@cstamas cstamas marked this pull request as ready for review December 11, 2025 14:03
Comment on lines +126 to +128
* The "no input outcome": if filter is enabled, but no input is available. By default, RRF filters without
* input would "stand aside" and just "allow", resulting in same outcome for "disabled" and "enabled but no input
* available" situations. This configuration allows to alter outcome for "enabled but no input available" case.
Copy link
Contributor

@gnodet gnodet Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The "no input outcome": if filter is enabled, but no input is available. By default, RRF filters without
* input would "stand aside" and just "allow", resulting in same outcome for "disabled" and "enabled but no input
* available" situations. This configuration allows to alter outcome for "enabled but no input available" case.
* Determines what happens when the filter is enabled but has no prefix data to work with.
* When set to `true` (default), the filter allows all requests to proceed. When set to `false`,
* the filter blocks requests when no prefix data is available.

@cstamas cstamas merged commit 0766f6b into apache:master Dec 11, 2025
14 checks passed
@cstamas cstamas deleted the enhance-rrf branch December 11, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants