GH-1737: Revert partially parallel upload change#1765
Conversation
Revert partially (connector only) commit: 09c3fa9 Fixes apache#1737
kwin
left a comment
kwin
left a comment
There was a problem hiding this comment.
Thanks, looks good. But deserves an clarification in the documentation of https://maven.apache.org/resolver/configuration.html for aether.connector.basic.parallelPut.
src/site/markdown/configuration.md
Outdated
| | `"aether.conflictResolver.versionSelector.selectionStrategy"` | `String` | The name of the version selection strategy to use in conflict resolution: "nearest" (default) or "highest". | `"nearest"` | 2.0.11 | No | Session Configuration | | ||
| | `"aether.connector.basic.downstreamThreads"` | `Integer` | Number of threads in basic connector for downloading. | `5` | 2.0.0 | Yes | Session Configuration | | ||
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. | `true` | 1.9.5 | Yes | Session Configuration | | ||
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT sequentially and the rest of PUTs in parallel. | `true` | 1.9.5 | Yes | Session Configuration | |
There was a problem hiding this comment.
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT sequentially and the rest of PUTs in parallel. | `true` | 1.9.5 | Yes | Session Configuration | | |
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT individually and only once completed the rest of PUTs in parallel. This is to make sure that receiving repository managers will be able to correctly prepare things like staging repos with the first request and associate the subsequent parallel ones to the first one. | `true` | 1.9.5 | Yes | Session Configuration | |
There was a problem hiding this comment.
@kwin this is generated markdown from Javadoc (and we did not know better than to check in generated file). The source is in Javadoc of this file:
https://github.com/apache/maven-resolver/pull/1765/changes#diff-53426dfed2b513628c93a211ce19725fb3fc8512f02e2ac2f2a093d871481ef2
There was a problem hiding this comment.
Sorry, forgot, I will look into preventing that checkin. Should be possible to leverage https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#generatedSiteDirectory for sources which are not manually maintained. Should I directly add commits to this branch?
|
I intentionally left out mentioning MRMs, just used your test for part that explains what happens (in Maven/Resolver). |
2 participants
Revert partially (connector only) commit:
09c3fa9
Fixes #1737