Use GET() and PUT() instead of method()#740
Merged
cstamas merged 1 commit intoapache:masterfrom Jun 11, 2025
Merged
Conversation
But this does not work for HEAD() that is 18+. Moreover, builder `method(String, BodyPublisher)` enforces body publisher as non-null, while the logic to stop emitting `Content-Length: 0` on GET and HEAD expects `null` body publisher. Fixes apache#739
cstamas
added
bug
slawekjaranowski
approved these changes
Jun 8, 2025
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
can we introduce a test for it? 😄
Member
Author
|
@slawekjaranowski like test "does JDK transport sends |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But this does not work for
HEAD()that is 18+.Moreover, builder
method(String, BodyPublisher)enforces body publisher as non-null, while the logic to stop emittingContent-Length: 0on GET and HEAD expectsnullbody publisher.This fixes:
GET()method on builder that will usenullbody publisher (and JDK bugfix will work)PUT()method on builderContent-Length: 0, but may be wrong). Fixing HEAD is not possible, as dedicatedHEAD()method was added in java 18, while the existingmethod(String, BodyPublisher)enforces non-null publisher.Fixes #739